Avoid Thymeleaf 3.1+ Forbidden Method Calls by Precomputing Class Simple Names - #53
Open
kristijanzafirovski wants to merge 4 commits into
Open
kristijanzafirovski wants to merge 4 commits into
kristijanzafirovski wants to merge 4 commits into
Conversation
|
When is this going to be uploaded? I was working with this and downgrading thymeleaf doesn't seem to be working neither. Edit: It worked downgrading SpringBoot starter version |
- Bump spring-boot-starter-parent to 4.1.1 and java.version to 26. - Fix source breakage from the Boot 4 / Spring Framework 7 API moves: ServletWebServerInitializedEvent relocated to org.springframework.boot.web.server.servlet.context, and Boot 4's web starter now pulls Jackson 3 (tools.jackson.*) instead of Jackson 2, so ObjectMapper/JsonProcessingException usage in DataExportController moves to tools.jackson.databind.ObjectMapper and the now-unchecked tools.jackson.core.JacksonException. - Replace the non-functional placeholder @SpringBootTest (this is a library with no bootable application, so a bare @SpringBootTest could never find a configuration class - it was already erroring before this change) with a real smoke test app that imports SnapAdminAutoConfiguration, boots a full Spring context, and hits the admin index and a model list route end-to-end. This is what previously crashed at startup on Spring Boot 4.1.1 when consumed as a published jar; it now builds and runs clean. - Bump the release workflow's JDK to 26 (temurin) to match. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CzTxQYQNrcQaCJnYNELDaa
- Add jitpack.yml: JitPack's default image (and SDKMAN) has no JDK 26, so every build since the Boot 4.1.1 upgrade failed and main-SNAPSHOT kept serving the pre-upgrade jar. Install Temurin 26 from Adoptium instead. - DbObject.get(): when a getter's return type doesn't match the mapped field (e.g. a display-only `String getComputer()` over a `Computer` relationship), read the field directly, unproxying Hibernate proxies. - findGetter/findSetter: support Lombok's naming for boolean fields named `isX` (isX() / setX()). - getValues/traverseMany: treat a null collection as empty. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces forbidden Class.getSimpleName() calls in templates with a precomputed javaClassSimpleName property from the backend. This resolves template errors on Spring Boot 3.x and Thymeleaf 3.1+.